Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing undefined proptype warning and reversed disableddates to enableddates #258

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

codGmer
Copy link

@codGmer codGmer commented Dec 5, 2020

fixing Warning: Invalid argument supplied to oneOfType. Expected an array of check functions, but received undefined at index 0.

and reversed disableddates to enableddates, maybe create both parameters?

@peacechen
Copy link
Collaborator

Thanks @codGmer for the PR. I like the positive prop versions e.g. enabledDates. There are existing projects using disabledDates and we shouldn't break them. Please restore the disabled* props and add your enabled* props alongside them. That way users can choose which one to use.

Another PR fixed the propTypes on selectedDayStyle, so please revert the changes to ViewPropTypes.style.

@peacechen
Copy link
Collaborator

@codGmer
Will you address the points above? Your contributions would be valued, but it needs to remain in sync with the main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants