Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add peerDependencies to package.json #90

Closed
JimmyDaddy opened this issue Sep 13, 2017 · 5 comments
Closed

add peerDependencies to package.json #90

JimmyDaddy opened this issue Sep 13, 2017 · 5 comments

Comments

@JimmyDaddy
Copy link

JimmyDaddy commented Sep 13, 2017

there are many issues caused by

"react": "~15.4.0",
"react-native": "0.42.3",

can you move them to

  "peerDependencies": {
    "react-native": ">=0.20.0",
    "react": ">=15.4.0
  },

???
@stephy thank you

@peacechen
Copy link
Collaborator

See #85
Solution is to use my fork until the PR is merged.

@afshinm
Copy link

afshinm commented Nov 1, 2017

@peacechen I appreciate your work and it does solve the problem but the correct solution is to use peerDependency not to remove them IMO.

@afshinm
Copy link

afshinm commented Nov 1, 2017

I have updated my fork using peerDependency and it works now: https://github.com/afshinm/JalaliCalendarPicker/blob/5fa59ad7b81d3e0edfbf83a9f16ed7ce87d79835/package.json#L17-L19

@JimmyDaddy
Copy link
Author

It seems the author doesn't maintain this package anymore

@peacechen
Copy link
Collaborator

peacechen commented Nov 16, 2017

Version 5.11.0 fixes this and has been published to npm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants