-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react-native in dependencies breaks build #85
Comments
Fixed it in my fork. Since there's an outstanding PR, that commit got lumped in with #84 |
ping @stephy |
@peacechen Could you please let me know how I can fix this error. I literally am spending hours to fix this. |
In your package.json, point to my fork until stephy merges and publishes an update.
Depending on the state of your project, you may need to delete node_modules and reinstall. |
Thanks @peacechen your fork does look to have solved the issue. |
@peacechen Hey Thanks for creating a fork and helping everyone out. I have been super busy! Where is the PR you created to solve this issue? I will merge it. |
PR #84 Includes the react-native dependency fix. It includes a number of other fixes & features. They are relatively minor and have been working well in our app for a while. |
Commit 6c253d9 re-introduced react-native to dependencies again. This results in the error Update UnableToResolve 'ActivityIndicator' due to a nested copy of react-native inside CalendarPicker.
@stephy : please prioritize removing it and publishing an update to npm as it's breaking any react-native project using this library.
The text was updated successfully, but these errors were encountered: