Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

remove deprecated usage of getExtension #211

Merged
merged 4 commits into from
Feb 18, 2019
Merged

remove deprecated usage of getExtension #211

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f09480d
remove deprecated usage of getExtension
kesslerdev Feb 15, 2019
fbaace6
Update composer.json
kesslerdev Feb 15, 2019
f5903d2
use TimelineExtension::class
kesslerdev Feb 18, 2019
5d4f74c
Update TimelineActionThemeNode.php
kesslerdev Feb 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Twig/Node/TimelineActionThemeNode.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public function compile(\Twig_Compiler $compiler)
{
$compiler
->addDebugInfo($this)
->write('echo $this->env->getExtension(\'timeline_render\')->setTheme(')
->write('echo $this->env->getExtension(\'Spy\TimelineBundle\Twig\Extension\TimelineExtension\')->setTheme(')
->subcompile($this->getNode('action'))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use fcqn here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what do you suggest? using timeline_render generates a deprecation.

Copy link
Owner

@stephpy stephpy Feb 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use TimelineExtension::class, then use

->raw(', array(')
;
Expand Down