fix error with stdout in callback - close #110

stephenlacy · Apr 5, 2016 · 72c823d · 72c823d
1 parent 1512a24
commit 72c823d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/lib/tag.js b/lib/tag.js
@@ -27,13 +27,13 @@ module.exports = function (version, message, opt, cb) {
   if (version !== '') {
     cmd += ' ' + signedarg + ' -m "' + message + '" ' + opt.args + ' ' + escape([version]);
   }
-  var templ = gutil.template(cmd, {file:message});
+  var templ = gutil.template(cmd, {file: message});
   return exec(templ, {cwd: opt.cwd}, function(err, stdout, stderr){
     if (err) return cb(err);
     if (!opt.quiet && version !== '') gutil.log(stdout, stderr);
     if (version === '') {
       stdout = stdout.split('\n');
     }
-    cb(stdout);
+    return cb();
   });
 };
diff --git a/test/tag.js b/test/tag.js
@@ -11,14 +11,17 @@ module.exports = function(git, testFiles, testCommit){
   // These must be run on a system which has git installed
   // no pull delay, and has git configured.
 
-
   it('should tag a version of the repo', function(done) {
-
     git.tag('v1.2.3', 'message', {cwd: './test/'}, function() {
       should.exist('test/.git/refs/tags/v1.2.3');
       done();
     });
-
   });
 
+  it('should not throw an error on success', function(done) {
+    git.tag('v2', 'message', {cwd: './test/'}, function(err) {
+      should.not.exist(err);
+      done();
+    });
+  });
 };