Supports webpack5 and mini-css-extract-plugin #199
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports webpack5 and mini-css-extract-plugin, with the following 3 changes:
tap/tapAsync/tapPromise
function, as mini-css-extract-plugin will use thecompilation
parameter passed to the tap function(code here), but it will get the proxy object instead of itself, which causes some bugs.compiler
for a similar reason as the first one, as some plugins require the original method, such asmini-css-extract-plugin
, which usescompile.webpack
as the cache. code herenormal-module-loader
hook, although it can still be used now, it will be removed in the future.I ran through all the test cases and it seems to be okay. I hope it helps :)