git clone workaround

[jeremyj563]

Background

A few days ago there was a .gitmodules file added to the official nvm repository:

• nvm-sh/nvm@29dce5e#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584

Unfortunately the URL used in that submodule is apparently not publicly accessible:

$ git clone git@github.com:nvm-sh/nvmrc.git /tmp/nvmrc

Cloning into '/tmp/nvmrc'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

$ gh repo clone git@github.com:nvm-sh/nvmrc.git /tmp/nvmrc

Cloning into '/tmp/nvmrc'...
git@github.com: Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
failed to run git: exit status 128

The problem for us is that for some reason the default value of ansible.builtin.git.recursive is true (which means all submodules will also be cloned):

• https://github.com/ansible/ansible/blob/devel/lib/ansible/modules/git.py#L150-L156

Solution

Therefore an obvious workaround is to simply set recursive to false - which is all this PR does...

To me it seems strange that the default behavior for the built-in git module is to do a recursive clone... though I highly doubt they would be willing to change that default value to false. Doing so would likely break git clone tasks for a large amount of people who depend on it implicitly.

We could also reach out to the nvm team to see if they could use a public repo URL for their submodule config...

Not sure what else we could do for a proper solution here.

[stephdewit]

Hello @jeremyj563

Thanks for the pull request.

A new release is available.