Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<frameset> causes "TypeError: MutationObserver.observe: Argument 1 is not an object" #153

Closed
mkeller opened this issue Jul 13, 2023 · 1 comment

Comments

@mkeller
Copy link
Contributor

mkeller commented Jul 13, 2023

FormHistoryControl log an error to the console when the user opens a page using the <frameset> tag.

To Reproduce

  1. Go to https://www.tutorialspoint.com/html/html_frames.htm
  2. See in browser console:
TypeError: MutationObserver.observe: Argument 1 is not an object. 3 [collectFormData.js:963:25](moz-extension://baedb3c4-9d4c-4c37-9592-7709714d6a1c/content/collectFormData.js)
    addBodyObserver moz-extension://baedb3c4-9d4c-4c37-9592-7709714d6a1c/content/collectFormData.js:963
    addAllHandlers moz-extension://baedb3c4-9d4c-4c37-9592-7709714d6a1c/content/collectFormData.js:1046
    <anonymous> moz-extension://baedb3c4-9d4c-4c37-9592-7709714d6a1c/content/collectFormData.js:1050
    inject resource://gre/modules/ExtensionContent.sys.mjs:581
    AsyncFunctionNext self-hosted:852

Expected behavior
No error. Support for <frameset>

Desktop

  • Firefox, Windows 10

Fix
in collectFormData.js:964, replace

        aDocument.querySelector("body"),

by

        aDocument.body,
mkeller added a commit to mkeller/formhistorycontrol-2 that referenced this issue Jul 13, 2023
@stephanmahieu
Copy link
Owner

Fixed in v2.5.7.1, released 18 October.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants