Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin named #7

Merged
merged 1 commit into from
Apr 13, 2016
Merged

plugin named #7

merged 1 commit into from
Apr 13, 2016

Conversation

stephanenicolas
Copy link
Owner

Named works. Built on top of both #4 and #5.

@dlemures
Copy link
Collaborator

👍 merge after solving conflicts.
You can merge this PR directly instead of the previous 2

Make member injectors use directly super member injectors.

Move to scope works and tested

Simplify syntax...:)

comment

Simpler Naming for smoothie modules

clean up

fix the renaming injector --> scope problem.
Add named instance creation :)
We fully support both @Inject @foo and @Inject @nAmed("foo") for instance injections.
TODO generalize it to providers.
TODO test it for methods and constructor parameters.
@stephanenicolas stephanenicolas merged commit dd3d692 into master Apr 13, 2016
@dlemures dlemures deleted the sni/plugin-named branch April 14, 2016 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants