Fix portable build of libmodbus (upstream) #793
Conversation
… files Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…string length Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Also define WARNING_CXXFLAGS even if not used at the moment; the script already does juggle CXXFLAGS and detects PROG_CXX anyway. Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…ds (mingw) Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…ntop() from NUT for cross-builds on WIN32 (mingw) Adapted to libmodbus codebase and clang-format Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…uires netinet/in.h explicitly included first Looking at FreeBSD, OpenIndiana et al. Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…e-bracket debug printout Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…, report it as such (not as generic "select()") Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…f() to sync the output Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
…tuations Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… contents in the final report Signed-off-by: Jim Klimov <jimklimov@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
…ementations Signed-off-by: Jim Klimov <jimklimov+nut@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
…move the old call Signed-off-by: Jim Klimov <jimklimov@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
… tooling Signed-off-by: Jim Klimov <jimklimov@gmail.com>
|
We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please fill https://forms.gle/5635zjphDo5JEJQSA to get added. Your document will be manually checked by the maintainer. Be patient... |
Upstream the work done for NUT fork of libmodbus, without the RTU USB pieces at the moment - see networkupstools#4 for the equivalent PR there
This subset of those changes focuses more strictly on passing builds without warnings, due to regressions allegedly due to upstream v3.1.10->v3.1.11 bump, so these fixes could be up-streamed separately:
rtu_usbbranch not as portable as they should be (printing of int types)setsockopt()pointer to datainet_ntop()/inet_pton()absent on Windows (at least MINGW on Linux cross-build environments, MSYS2 does not seem to suffer this one) -configuredetection and fallback implementation code imported from NUTip.hneedsin.hexplicitly on some platformsEnhancements:
./configure --enable-Werrorin test builds, to fail the build upon any compiler warnings (not enabled by default), allowing to easily iterate on the code fixesThere is a separate stack of commits focused on passing
make checkas well -- the unit-test changes in networkupstools#3, but those are a bit more questionable even to myself (e.g. should flushing be done between tests and/or if some fail? how much should we rely on tight timings in "7ms > 5ms" tests where OS clock for context switches may be not so precise? etc.)NOTE: I've posted the form for CLA bot some weeks ago, did not see any master-branch changes about that though. Posted another today, just in case.