[text-format] Fix parsing of string literals #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add some test that would fail without this PR? |
stepancheg
requested changes
Jun 26, 2024
| /// The raw bytes for a single char or escape sequence in a string literal | ||
| /// | ||
| /// The raw bytes are available via an `into_iter` implementation. | ||
| pub struct DecodedBytes { |
There was a problem hiding this comment.
This seems to be not used outside of the crate, so it should not be public.
There was a problem hiding this comment.
It's the return type of a public method, so it needs to be pub. We could modify that signature to return impl Iterator, if that is preferable?
This renames `next_byte_value` to `next_str_lit_bytes` and may return between 1..=4 bytes per call, representing the variable-length nature of the UTF-8 encoding.
cmyr
force-pushed
the
parse-unicode-strings
branch
from
0eaddf2
to
59d6e61
Compare
|
I've added a test case that fails without this patch but passes with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This renames
next_byte_valuetonext_str_lit_bytesand changes the signature so that it returns between 1..=4 bytes per call, representing the variable-length nature of the UTF-8 encoding.note: I'm not sure how best to add tests for this, and it needs it; in particular there should be a test case of a text-format input that contains a non-ascii string literal. There should probably also be more tests for the weird byte escapes? But definitely a case with non-ascii text.