This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
Dereference the Arc before calling methods on the interface #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling methods on
Arc<MyService>
where the method is also defined on Arc (e.g.drop
andclone
), calling handler_copy.method(o, p) will actually attempt to call the Arc method instead of the method on the service, resulting in a compiler error. This change removes the ambiguity by dereferencing theArc
.An alternative fix would be to use the fully qualified syntax for method calls (yonran@d5d7f4c). I believe that this change should be good enough because H is only known to be
H : HelloService + 'static + Sync + Send + 'static
, andSync
andSend
define no other methods.