docs(dist-custom-elements): update documentation to reflect index.js changes #883
Conversation
alicewriteswrongs
changed the title
alicewriteswrongs
force-pushed
the
ap/dist-custom-elements-export
branch
from
4b0d3b2 to
b925122
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| defineCustomElement as defineCustomElementMyOtherComponent | ||
| } from './my-other-component.js'; | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Can we add a snippet of how this could be used as well? Right now, we tell folks that we'll export this file for them, but we don't give them much instruction as to how to use it compared to the first option (and probably should make that callout that this is an either/or proposition)
There was a problem hiding this comment.
that makes sense, I'll add an explanation of the specific use-case of setting this ad module in package.json, do you think there's anything else we should call out?
There was a problem hiding this comment.
🤔 I don't think so - with that we should be good!
There was a problem hiding this comment.
just realized there's a bit of a wrinkle with this...
…changes This adds documentation of the change to the `dist-custom-elements` output target introduced in stenciljs/core#3368. That PR adds a re-export of all the built components from the `index.js` file, which will support some existing workflows based on the `dist-custom-elements-bundle` output target.
alicewriteswrongs
force-pushed
the
ap/dist-custom-elements-export
branch
from
f324e66 to
0bec636
Compare
|
@rwaskiewicz I just updated this to reflect the changes to generation typedefs for |
Co-authored-by: Anthony Giuliano <67711678+a-giuliano@users.noreply.github.com>
This adds documentation of the change to the
dist-custom-elementsoutput target introduced in stenciljs/core#3368. That PR adds
a re-export of all the built components from the
index.jsfile,which will support some existing workflows based on the
dist-custom-elements-bundleoutput target.