docs(config): update updating guide for transformAliasedImportPaths #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
2 tasks
rwaskiewicz
added a commit
to stenciljs/core
that referenced
this pull request
May 24, 2023
rwaskiewicz
force-pushed
the
rwaskiewicz/v4-dev-init
branch
from
f9ff307 to
97d0c67
Compare
rwaskiewicz
added a commit
to stenciljs/core
that referenced
this pull request
Jun 2, 2023
rwaskiewicz
added a commit
to stenciljs/core
that referenced
this pull request
Jun 2, 2023
rwaskiewicz
added a commit
to stenciljs/core
that referenced
this pull request
Jun 21, 2023
rwaskiewicz
added a commit
to stenciljs/core
that referenced
this pull request
Jun 21, 2023
rwaskiewicz
force-pushed
the
rwaskiewicz/transformAliasedPathsTrueDocs
branch
from
3c7002e to
8e949d1
Compare
rwaskiewicz
requested review from
alicewriteswrongs and
tanner-reits
and removed request for
a team
docs/output-targets/dist.md
Outdated
| :::tip | ||
| If using the `dist-collection` output target directly, the same result can be achieved using the `transformAliasedImportPaths` flag on the target's config. | ||
| If using the `dist-collection` output target directly, the same result can be achieved using the [`transformAliasedImportPaths`](../config/01-overview.md#transformaliasedimportpaths) flag on the target's config. |
There was a problem hiding this comment.
This link points to the top-level config flag not the one for the dist-collection target specifically.
I think it's probably the right move, but I think we're a little too close to the release to change this right now. I think enabling them by default will mitigate this a little bit (it's just "on"), and something I'd be interested in coalesing for v5 |
tanner-reits
approved these changes
Jun 23, 2023
alicewriteswrongs
approved these changes
Jun 23, 2023
this commit updates the upgrade guide for stencil v4 to include new default values for `transformAliasedImportPaths` and `transformAliasedImportPathsInCollection`. STENCIL-829
rwaskiewicz
force-pushed
the
rwaskiewicz/transformAliasedPathsTrueDocs
branch
from
4090dda to
1cfaa11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit updates the upgrade guide for stencil v4 to include new default values for
transformAliasedImportPathsandtransformAliasedImportPathsInCollection.STENCIL-829
Core PR: stenciljs/core#4418