Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jest): remove version qualifiers in v27 facade impl #4950

Merged

Conversation

rwaskiewicz
Copy link
Contributor

@rwaskiewicz rwaskiewicz commented Oct 19, 2023

What is the current behavior?

See 'new behavior' section

GitHub Issue Number: N/A

What is the new behavior?

remove the import aliases used in jest-facade.ts. the aliases were renaming the imports to be '27-specific'. however, we're already in a 'jest-27' directory and working on the Jest27Stencil class (which is kept with the '27' to help differentiate this class further). having these extra import aliases made the instructions for adding a new version of jest more onerous than it needed to be

Does this introduce a breaking change?

  • Yes
  • No

Testing

These aliases were internal only to this file - I don't expect them to affect any other parts of the code.

Other information

remove the import aliases used in `jest-facade.ts`. the aliases were
renaming the imports to be '27-specific'. however, we're already in a
'jest-27' directory and working on the `Jest27Stencil` class (which is
kept with the '27' to help differentiate this class further). having
these extra import aliases made the instructions for adding a new
version of jest more onerous than it needed to be
@github-actions
Copy link
Contributor

--strictNullChecks error report

Typechecking with --strictNullChecks resulted in 1399 errors on this branch.

That's the same number of errors on main, so at least we're not creating new ones!

reports and statistics

Our most error-prone files
Path Error Count
src/dev-server/index.ts 37
src/mock-doc/serialize-node.ts 36
src/dev-server/server-process.ts 32
src/compiler/build/build-stats.ts 27
src/compiler/output-targets/dist-lazy/generate-lazy-module.ts 25
src/compiler/style/test/optimize-css.spec.ts 23
src/testing/puppeteer/puppeteer-element.ts 23
src/compiler/prerender/prerender-main.ts 22
src/runtime/vdom/vdom-render.ts 20
src/runtime/client-hydrate.ts 19
src/screenshot/connector-base.ts 19
src/compiler/config/test/validate-paths.spec.ts 16
src/dev-server/request-handler.ts 15
src/compiler/prerender/prerender-optimize.ts 14
src/compiler/sys/stencil-sys.ts 14
src/compiler/transpile/transpile-module.ts 14
src/runtime/vdom/vdom-annotations.ts 14
src/sys/node/node-sys.ts 14
src/compiler/build/build-finish.ts 13
src/compiler/prerender/prerender-queue.ts 13
Our most common errors
Typescript Error Code Count
TS2345 424
TS2322 398
TS18048 310
TS18047 100
TS2722 38
TS2532 34
TS2531 23
TS2454 14
TS2352 13
TS2769 10
TS2790 10
TS2538 8
TS2344 5
TS2416 4
TS2493 3
TS18046 2
TS2684 1
TS2488 1
TS2430 1

Unused exports report

There are 12 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!

Unused exports
File Line Identifier
src/runtime/bootstrap-lazy.ts 21 setNonce
src/screenshot/screenshot-fs.ts 18 readScreenshotData
src/testing/testing-utils.ts 198 withSilentWarn
src/utils/index.ts 145 CUSTOM
src/compiler/app-core/app-data.ts 25 BUILD
src/compiler/app-core/app-data.ts 115 Env
src/compiler/app-core/app-data.ts 117 NAMESPACE
src/compiler/fs-watch/fs-watch-rebuild.ts 123 updateCacheFromRebuild
src/compiler/types/validate-primary-package-output-target.ts 62 satisfies
src/compiler/types/validate-primary-package-output-target.ts 62 Record
src/testing/puppeteer/puppeteer-declarations.ts 485 WaitForEventOptions
src/compiler/sys/fetch/write-fetch-success.ts 7 writeFetchSuccessSync

@rwaskiewicz rwaskiewicz marked this pull request as ready for review October 19, 2023 18:31
@rwaskiewicz rwaskiewicz requested a review from a team as a code owner October 19, 2023 18:31
@rwaskiewicz rwaskiewicz added this pull request to the merge queue Oct 23, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2023
@rwaskiewicz rwaskiewicz added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit eb3ae9a Oct 23, 2023
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/refactor-jest-27-remove-version-qualifier branch October 23, 2023 19:45
rwaskiewicz added a commit that referenced this pull request Oct 24, 2023
copy the contents of `jest-27-and-under/` to a new `jest/` subdirectory,
`jest-28`. this directory contains an exact replica of
`jest-27-and-under/` as of 6893954 (#4904).

note that since then, eb3ae9a (#4950) has landed. this is handled in a
subesquent commit
rwaskiewicz added a commit that referenced this pull request Oct 24, 2023
this commit accounts for #4950 not having landed when the `jest-28`
directory was created - it effectively does the same work
rwaskiewicz added a commit that referenced this pull request Oct 24, 2023
copy the contents of `jest-27-and-under/` to a new `jest/` subdirectory,
`jest-28`. this directory contains an exact replica of
`jest-27-and-under/` as of 6893954 (#4904).

note that since then, eb3ae9a (#4950) has landed. this is handled in a
subesquent commit
rwaskiewicz added a commit that referenced this pull request Oct 24, 2023
this commit accounts for #4950 not having landed when the `jest-28`
directory was created - it effectively does the same work
rwaskiewicz added a commit that referenced this pull request Oct 26, 2023
copy the contents of `jest-27-and-under/` to a new `jest/` subdirectory,
`jest-28`. this directory contains an exact replica of
`jest-27-and-under/` as of 6893954 (#4904).

note that since then, eb3ae9a (#4950) has landed. this is handled in a
subesquent commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants