feat(typescript): update to typescript 5.2 #4852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Path | Location | Error | Message |
|---|---|---|---|
| src/dev-server/client/hmr-images.ts | (46, 46) | TS2345 |
reports and statistics
Our most error-prone files
| Path | Error Count |
|---|---|
| src/dev-server/index.ts | 37 |
| src/mock-doc/serialize-node.ts | 36 |
| src/dev-server/server-process.ts | 32 |
| src/compiler/build/build-stats.ts | 27 |
| src/compiler/output-targets/dist-lazy/generate-lazy-module.ts | 25 |
| src/compiler/style/test/optimize-css.spec.ts | 23 |
| src/runtime/vdom/vdom-render.ts | 23 |
| src/testing/puppeteer/puppeteer-element.ts | 23 |
| src/compiler/prerender/prerender-main.ts | 22 |
| src/runtime/client-hydrate.ts | 19 |
| src/screenshot/connector-base.ts | 19 |
| src/compiler/config/test/validate-paths.spec.ts | 16 |
| src/dev-server/request-handler.ts | 15 |
| src/compiler/prerender/prerender-optimize.ts | 14 |
| src/compiler/sys/stencil-sys.ts | 14 |
| src/compiler/transpile/transpile-module.ts | 14 |
| src/runtime/vdom/vdom-annotations.ts | 14 |
| src/sys/node/node-sys.ts | 14 |
| src/compiler/build/build-finish.ts | 13 |
| src/compiler/prerender/prerender-queue.ts | 13 |
Our most common errors
| Typescript Error Code | Count |
|---|---|
| TS2345 | 436 |
| TS2322 | 413 |
| TS18048 | 321 |
| TS18047 | 99 |
| TS2722 | 38 |
| TS2532 | 36 |
| TS2531 | 25 |
| TS2454 | 15 |
| TS2352 | 13 |
| TS2769 | 10 |
| TS2790 | 10 |
| TS2538 | 8 |
| TS2344 | 5 |
| TS2416 | 4 |
| TS2493 | 3 |
| TS18046 | 2 |
| TS2684 | 1 |
| TS2488 | 1 |
| TS2464 | 1 |
| TS2430 | 1 |
Unused exports report
There are 12 unused exports on this PR. That's the same number of errors on main, so at least we're not creating new ones!
Unused exports
| File | Line | Identifier |
|---|---|---|
| src/runtime/bootstrap-lazy.ts | 21 | setNonce |
| src/screenshot/screenshot-fs.ts | 18 | readScreenshotData |
| src/testing/testing-utils.ts | 198 | withSilentWarn |
| src/utils/index.ts | 140 | CUSTOM |
| src/compiler/app-core/app-data.ts | 25 | BUILD |
| src/compiler/app-core/app-data.ts | 114 | Env |
| src/compiler/app-core/app-data.ts | 116 | NAMESPACE |
| src/compiler/fs-watch/fs-watch-rebuild.ts | 110 | updateCacheFromRebuild |
| src/compiler/types/validate-primary-package-output-target.ts | 62 | satisfies |
| src/compiler/types/validate-primary-package-output-target.ts | 62 | Record |
| src/testing/puppeteer/puppeteer-declarations.ts | 485 | WaitForEventOptions |
| src/compiler/sys/fetch/write-fetch-success.ts | 7 | writeFetchSuccessSync |
rwaskiewicz
requested changes
Sep 27, 2023
alicewriteswrongs
force-pushed
the
ap/ts-5.2
branch
from
d8ee609 to
9af43f3
Compare
alicewriteswrongs
changed the title
rwaskiewicz
approved these changes
Sep 27, 2023
|
@alicewriteswrongs can you open a PR to update the Doc Site's table for TS support? |
|
oops forgot to copy-paste it! it's up already: stenciljs/site#1238 |
tanner-reits
approved these changes
Sep 28, 2023
This upgrades us to TypeScript 5.2.2. The only change we had to make was to adjust the `module` setting in `scripts/package.json` in order to account for this change: https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/#module-and-moduleresolution-must-match-under-recent-node-js-settings
alicewriteswrongs
force-pushed
the
ap/ts-5.2
branch
from
9af43f3 to
d3aa1f8
Compare
alicewriteswrongs
added a commit
to stenciljs/site
that referenced
this pull request
Sep 28, 2023
This adds an entry to the table where we note the versions of Stencil where we upgrade TypeScript to include information about the forthcoming upgrade to TypeScript 5.2.2 in Stencil 4.4.0. See also stenciljs/core#4852
alicewriteswrongs
added a commit
to stenciljs/site
that referenced
this pull request
Sep 28, 2023
This adds an entry to the table where we note the versions of Stencil where we upgrade TypeScript to include information about the forthcoming upgrade to TypeScript 5.2.2 in Stencil 4.4.0. See also stenciljs/core#4852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the TS 5.2 upgrade. In order to get the project to build I didn't have to do much other than install the package.
I did have to adjust the
modulesetting inscripts/package.json, to account for this change: https://devblogs.microsoft.com/typescript/announcing-typescript-5-2/#module-and-moduleresolution-must-match-under-recent-node-js-settingsWhat is the current behavior?
Yucky, old, awful typescript 5.1!
What is the new behavior?
TypeScript 5.2
Does this introduce a breaking change?
Testing
After upgrading the package I built it locally and installed it into Framework and checked that Framework builds with no issues and the tests run.
Other information