-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mock-doc): add matrix and tspan props for svgelement #3408
Merged
rwaskiewicz
merged 12 commits into
stenciljs:main
from
marlon-ionic:mh/test-mockdoc-svg
Jun 13, 2022
Merged
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
5dc7c14
feat(mock-doc): add matrix and tspan props for svg
marlon-ionic 796f66e
added blur(), focus() to MockElement
marlon-ionic ff86348
rm focus() from SVGElement, rename defaultMatrix
marlon-ionic 6acc410
update svg testing
marlon-ionic 060a939
Merge branch 'main' into mh/test-mockdoc-svg
marlon-ionic 46a3b86
Update src/mock-doc/test/html-parse.spec.ts
marlon-ionic dc878cc
Update src/mock-doc/element.ts
marlon-ionic 8c870de
added subest of svg child elements
marlon-ionic 587b349
update MockDOMPoint
marlon-ionic b6804a2
Merge branch 'main' into mh/test-mockdoc-svg
rwaskiewicz d9e2ea0
apply strictNullChecks patch to html-parse.spect.ts
marlon-ionic 29f49bf
Merge branch 'mh/test-mockdoc-svg' of https://github.com/marlon-ionic…
marlon-ionic File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had this question in the original implementation that I think still stands
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh sorry, I missed responding to this one! I don't know. I simply used the default values returned when a DOMMatrix is instantiated (see screenshot).
