Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default distignore #12

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Fix default distignore #12

merged 2 commits into from
Dec 20, 2023

Conversation

estevao90
Copy link
Contributor

@estevao90 estevao90 commented Dec 20, 2023 •
edited
Loading

Fix the default distignore to avoid skipping files with bin and tests in their name.

borkweb
borkweb approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@borkweb borkweb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is incredibly complex. I can't wrap my mind around this architectural shift, so I'll just green light the PR. 🚦

@estevao90 estevao90 merged commit 5e57cf4 into main Dec 20, 2023
2 checks passed
@bordoni bordoni deleted the fix-default-distignore branch April 27, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borkweb borkweb borkweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estevao90 @borkweb