Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependences, register block metadata, & use components, icons, and helpers from repos #618

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

oakesjosh
Copy link
Contributor

@oakesjosh oakesjosh commented Nov 25, 2024

This shouldn't be merged into master yet -- Opening a PR for dev testing, then we can send to support for testing. Not trying to tie this to a specific release or date.

This can be a pain to switch back and forth locally. A rm -rf node_modules and fresh install is needed. We no longer need the --legacy-peer-deps when doing an npm install though. Then install the submodules git submodule update --init --recursive. To switch back to a previous branch you'll have to delete the 3 submodule directories. rm -rf src/packages/{components,helpers,icons}

What this does

  • Replace dr-kobros/react-webfont-loader in the KadecnceWebFontLoader and FontLoader components.

  • Replace react-container-dimensions with similar function named ContainerDimensions in column-drag-resizer/index,js component.

  • Update react-select

  • Update @wordpress/i18n

  • Update @wordpress/scripts

  • Generally updated dependences

  • Update the gulp files to not call deprecated functions

  • Update scss files processed by gulp to use @use instead of deprecated @import.

Support new 6.7 block manifest metadata registration

With the updated @wordpress/scripts we can use the new wp-scripts build-blocks-manifest. This is registered in kadence-blocks.php. This improves performance since PHP only has to read and parse a single file from the server to get all block metadata. When attempting the register the blocks later, i'll check if it's already pulled in the metadata before opening the blocks specific block.json.

Moving packages to repos

  • Delete existing /src/packages/{components, icons, helpers}
  • Add submodule for components, icons, helpers

@mark-c-woodard
Copy link
Contributor

Did not see any issues walking around the block editor, a few different blocks, a slew of settings, just using free, free and pro, the header and a few frontend pages.

I think this should move forward.

@mark-c-woodard
Copy link
Contributor

Actually did find one thing
image
image

Looks like the flex settings on the section block are wonky.

I also get an error when trying to use the reset on the vertical gap setting there.

@mark-c-woodard mark-c-woodard self-requested a review December 3, 2024 21:26
Copy link
Contributor

@mark-c-woodard mark-c-woodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants