Generate MarhsalXDR() instead of EncodeTo() #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
commented
Nov 10, 2021
Comment on lines
-342
to
+338
| out.puts "func (s *#{name}) EncodeTo(e *xdr.Encoder) error {" | ||
| out.puts " var err error" | ||
| out.puts "// MarshalXDR implements xdr.Marshaler." | ||
| out.puts "func (s #{name}) MarshalXDR(e *xdr.Encoder) (int, error) {" |
There was a problem hiding this comment.
Unfortunately, I am forced to call by value (note the lack of *) when switching to MarshallXDR)() since, otherwise, xdr.Encoder() cannot invoke the method on unadresable values.
Calling by value, which can (and as I observed, it does) cause allocations (due to the copy variables not fitting in the stack), betraying the purpose of doing all this (which is increasing performance).
|
I'm closing this PR, due to the reasons outlined above. |
This was referenced Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdrgen counterpart to stellar/go-xdr#17