Add Make Job to GitHub Workflow #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 47deb6fb6aa42233be5e14a1487cb8d2adaca3cc)
dmkozh
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds a new 'make' job to the GitHub workflow to test the local Makefile.
Pin the make job to ruby 3.3.
Why
Ensures that the Makefile works correctly and generates expected test outputs during continuous integration. I noticed in @overcat's PR below that the tests pass in CI, but the Makefile doesn't locally.
As @overcat pointed out in that other PR, the Makefile doesn't pin to a version of ruby and xdrgen currently doesn't build with ruby 3.4.