-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(java): Remove the dependency on third-party libraries. #168
refactor(java): Remove the dependency on third-party libraries. #168
Conversation
Hi @sreuland, can you review this PR? |
sure, this pr is large, can you provide some guidance on where to start or drill down from, etc to understand the change for context? |
This PR is actually not that big, it looks big because most of the changes are generated code from testing. We mainly need to focus on the changes in the |
Based on this PR, we can generate the changes required for lightsail-network/java-stellar-sdk#525. |
ok, that helps, looks good. Are there tests locally in this repo to confirm the generated java code is compiling, no additional warnings/errors? |
There is currently no such test. |
The code generated by this PR has been applied to lightsail-network/java-stellar-sdk#525, and the CI is already green. If we want to verify whether the Java code in this repo can be compiled, let's create a new issue to discuss how to add it. |
ok, that could be a follow-on ticket to capture tech debt type. This pr is ready to merge correct? |
Yes, it's ready. |
Now, we relied on Guava. I think this is unnecessary. Let's remove it and use alternatives in the standard library.