Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP31: Added SEP-12 logic #660

Merged
merged 10 commits into from
Jul 6, 2020
Merged

Conversation

JakeUrban
Copy link
Contributor

@JakeUrban JakeUrban commented Jul 1, 2020

resolves stellar/integration-meta#147

Added the ability to use SEP-12 for KYC'ing senders and receivers of SEP-31 transactions.

  • Changes the format of the GET /info response to include sender_sep12_type and receiver_sep12_type
  • Removed fields other than memo in the sender and receiver objects for GET /info and POST /send
  • Changed the customer_info_needed error response to signal a required update to the SEP-12 PUT /customer endpoint
  • Renamed the original customer_info_needed error response to transaction_info_needed
  • Changed pending_info_update Transaction status to pending_transaction_info_update
  • Added pending_customer_info_update Transaction status for updates to SEP-12 PUT /customer

@JakeUrban JakeUrban requested a review from msfeldstein July 1, 2020 20:35
ecosystem/sep-0031.md Outdated Show resolved Hide resolved
ecosystem/sep-0031.md Outdated Show resolved Hide resolved
ecosystem/sep-0031.md Outdated Show resolved Hide resolved
ecosystem/sep-0031.md Outdated Show resolved Hide resolved
ecosystem/sep-0031.md Show resolved Hide resolved
ecosystem/sep-0031.md Outdated Show resolved Hide resolved
@JakeUrban
Copy link
Contributor Author

This isn't ready yet. We'll likely wait for the SEP-12 changes to land before merging this, and there are still some adjustments we're considering.

Copy link
Contributor

@msfeldstein msfeldstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JakeUrban JakeUrban merged commit d42159a into stellar:master Jul 6, 2020
@JakeUrban JakeUrban deleted the sep12-for-sep31 branch July 6, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants