soroban-cli: error messages saying to use config identity fund suggest a broken command

[leighmcculloch]

What version are you using?

20.0.0-rc3

What did you do?

• 🕴🏻 Generated a new identity.
• 🚀 Attempted to use it to deploy a contract.
• 🤦🏻 See an error message saying the identity's account does't exist.
• 💻 Ran the command the error message said to run.

❯ soroban config identity generate me
❯ soroban contract deploy --network local --source me --wasm contract.wasm
error: Account not found: GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF
Might need to fund account like:
soroban config identity fund GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF --network <name>
soroban config identity fund GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF --helper-url <url>
❯ soroban config identity fund GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF --network local
...

What did you expect to see?

• Success!

❯ soroban config identity fund GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF --network local

What did you see instead?

• A message saying the identity can't be found.

❯ soroban config identity fund GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF --network local
error: Failed to find config identity for GDVYX75NCSGCVPVE6LS43DGK643NKJRETSFPXHSYCQIAMBIYVIAZXOJF

Discussion

It seems that the error message thinks it should be possible to fund any G address. However the fund command appears to only accept an identity name, not a G address.

For example, the following command works:

❯ soroban config identity fund me --network local

The immediate fix is probably to fix the error message.

But the better fix would be to "fix" the fund command so it lets you fund any G address.