Add an attribute macro for trait impls that extern the trait fns #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leighmcculloch
changed the title
|
This is very incomplete, but I'm going to merge this so that we can start using it. It has enough functionality to generate extern functions, and it fills a custom section containing some bogus strings that aren't super useful, but will be replaced by XDR in following PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add an attribute macro for trait implementations that creates extern fns for each fns in the trait being implemented.
Why
To reuse Rust traits as a way to specify the public API of a contract, to share that API with others, and to leverage the Rust compiler to validate a contract interface. See #42 for further discussion.
Close #114
Known limitations
This PR is incomplete, a WIP, starting with the attribute macro previously attempted from #9.