Add a little more infrastructure for building ConversionErrors #235
Conversation
| if let Err(e) = self.debug_event(DebugEvent::new().msg("type conversion failed")) { | ||
| return e; | ||
| } | ||
| if let Err(e) = self.debug_event(DebugEvent::new().msg(core::any::type_name::<T>()).arg(v)) |
There was a problem hiding this comment.
I think we can combine these two debug events.
Can we format a msg to include the typename? The typename should be known at compile time, and this fn is generic and bound to the type at compile time, so it should be possible to compose the type conversion into T failed string at compile time.
(We'd need to use something like the const_format crate.)
If we can't do that for some reason, can we truncate and convert the T typename into a Symbol and include it as an arg?
There was a problem hiding this comment.
This PR is to just check in Graydon's changes during today's meeting so that I can pick it up and continue on.
There was a problem hiding this comment.
Oh neat, I hadn't seen const_format. Maybe! I will also be fleshing out support for multiple static strings (host and guest) as args beyond the initial msg, so this is very much a stopgap, not the final version.
There was a problem hiding this comment.
Hmm, I couldn't figure out how to do it with one debug_event.
const_format (e.g. concatcp! ) doesn't help here because the inputs must be const.
Is there any way to get the compile-time type names?
There was a problem hiding this comment.
Ah, so the core::any::typename is a const fn, but only in nightly behind the const_type_name feature. Doh! rust-lang/rust#63084
|
Closing this as I've incorporated the changes into my follow-up work. |
A little promised code from meeting earlier today, sorry for delay @jayz22 !