Check for a global EventSource before deciding what to use. #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This approach gives you the flexibility to inject polyfills in other environments like react-native.
morleyzhi
reviewed
Jul 26, 2019
| @@ -149,7 +151,10 @@ export class CallBuilder< | |||
| createEventSource(); | |||
| return function close() { | |||
There was a problem hiding this comment.
I noticed before that this function keeps trying to write to es even if the assignment fails. I feel like it should return in the catch rather than continuing with the function. Can you make that fix too?
fnando
force-pushed
the
global-eventsource
branch
from
cf6f949
to
7f7e416
Compare
morleyzhi
approved these changes
Jul 26, 2019
lhtdeepaktomar
pushed a commit
to lhtdeepaktomar/js-stellar-sdk
that referenced
this pull request
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach gives you the flexibility to inject polyfills in other environments like react-native.