Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Network Deprecation warning should give line #415

Closed
msfeldstein opened this issue Aug 20, 2019 · 2 comments · Fixed by stellar/js-stellar-base#300
Closed

Global Network Deprecation warning should give line #415

msfeldstein opened this issue Aug 20, 2019 · 2 comments · Fixed by stellar/js-stellar-base#300
Labels
bug Hacktoberfest suggested issues for Hacktoberfest

Comments

@msfeldstein
Copy link
Contributor

msfeldstein commented Aug 20, 2019

I keep getting this deprecation warning Global class `Network` is deprecated. Please pass explicit argument instead, e.g. `new Transaction(envelope, Networks.PUBLIC)` (see https://git.io/fj9fG for more info). but it gives me no insight into where its coming from. It should give me the line number that's causing it so i can fix it.

@saingsab
Copy link

saingsab commented Aug 28, 2019

If you use this StellarSdk.Networks.useTestNetwork() try to switch to this.
StellarSdk.Networks.TESTNET

I am not so clear about this change. hopefully its works

@theclabs
Copy link

theclabs commented Sep 6, 2019

It should give me the line number that's causing it so i can fix it.

Although in the link we can quickly understand the reason for the warning, I think it is a good idea to show the line that generates the warning to go quickly to solve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Hacktoberfest suggested issues for Hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants