Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v11.0.1 #735

Merged
merged 5 commits into from
Mar 20, 2024
Merged

Release v11.0.1 #735

merged 5 commits into from
Mar 20, 2024

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Mar 20, 2024

No description provided.

@Shaptic Shaptic requested review from overcat, sreuland and a team March 20, 2024 18:02
Copy link

Size Change: -198 B (0%)

Total Size: 3.2 MB

Filename Size Change
dist/stellar-base.js 2.35 MB -131 B (0%)
dist/stellar-base.min.js 853 kB -67 B (0%)

compressed-size-action

Copy link

socket-security bot commented Mar 20, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@babel/cli@7.24.1 Transitive: eval, filesystem, network, shell +5 1.04 MB nicolo-ribaudo
npm/@babel/code-frame@7.24.2 environment +4 114 kB nicolo-ribaudo
npm/@babel/compat-data@7.24.1 None 0 64.6 kB nicolo-ribaudo
npm/@babel/eslint-parser@7.24.1 unsafe +2 164 kB nicolo-ribaudo
npm/@babel/helper-plugin-utils@7.24.0 None 0 11.7 kB nicolo-ribaudo
npm/@babel/parser@7.24.1 None 0 1.88 MB nicolo-ribaudo
npm/@babel/template@7.24.0 None 0 68.9 kB nicolo-ribaudo
npm/@babel/types@7.24.0 environment +3 2.5 MB nicolo-ribaudo
npm/@jridgewell/resolve-uri@3.1.2 None 0 53.2 kB jridgewell
npm/@jridgewell/trace-mapping@0.3.25 None 0 169 kB jridgewell
npm/@types/eslint@8.56.6 None 0 192 kB types
npm/@types/node@20.11.30 None +1 2.09 MB types
npm/@webassemblyjs/ast@1.12.1 None +5 431 kB xtuc
npm/@webassemblyjs/wasm-parser@1.12.1 None +7 391 kB xtuc
npm/browserslist@4.23.0 environment, filesystem Transitive: shell +6 2.4 MB ai
npm/call-bind@1.0.7 None +4 87.8 kB ljharb
npm/core-js-compat@3.36.1 None 0 717 kB zloirock
npm/define-data-property@1.1.4 None +2 50.4 kB ljharb
npm/elliptic@6.5.5 None +2 148 kB indutny
npm/es-abstract@1.22.5 None +34 2.72 MB ljharb
npm/eslint-webpack-plugin@4.1.0 filesystem Transitive: environment, shell +14 793 kB evilebottnawi
npm/eslint@8.57.0 environment, filesystem Transitive: unsafe +51 7.64 MB eslintbot
npm/flatted@3.3.1 None 0 40.3 kB webreflection
npm/has-property-descriptors@1.0.2 None +1 22.7 kB ljharb
npm/has-proto@1.0.3 None 0 12 kB ljharb
npm/hash-base@3.0.4 None 0 6.03 kB dcousens
npm/hasown@2.0.2 None +1 40.2 kB ljharb
npm/is-shared-array-buffer@1.0.3 None 0 18.7 kB ljharb
npm/istanbul-reports@3.1.7 Transitive: filesystem +5 374 kB oss-bot
npm/karma-firefox-launcher@2.1.3 environment, filesystem, shell +4 52.9 kB karmarunnerbot
npm/karma@6.4.3 environment, filesystem, network, shell Transitive: eval, unsafe +73 5.15 MB karmarunnerbot
npm/parse-asn1@5.1.7 Transitive: unsafe +1 71.4 kB ljharb
npm/safe-array-concat@1.1.2 None +1 19.8 kB ljharb
npm/side-channel@1.0.6 None +1 120 kB ljharb
npm/sodium-native@4.0.10 Transitive: environment, filesystem +1 4.49 MB mafintosh
npm/string.prototype.trim@1.2.9 None +39 833 kB ljharb
npm/string.prototype.trimend@1.0.8 None +1 31.3 kB ljharb
npm/typescript@5.4.2 None 0 32.4 MB typescript-bot
npm/which-typed-array@1.1.15 None +4 92.7 kB ljharb

🚮 Removed packages: npm/@babel/cli@7.23.9, npm/@babel/compat-data@7.23.5, npm/@babel/core@7.23.9, npm/@babel/eslint-parser@7.23.10, npm/@babel/helper-plugin-utils@7.22.5, npm/@babel/parser@7.23.9, npm/@babel/plugin-transform-optional-chaining@7.23.4, npm/@babel/preset-env@7.23.9, npm/@babel/template@7.23.9, npm/@babel/types@7.23.9, npm/@jridgewell/gen-mapping@0.3.3, npm/@jridgewell/resolve-uri@3.1.1, npm/@jridgewell/trace-mapping@0.3.22, npm/@types/eslint@8.56.2, npm/@types/node@20.11.17, npm/@webassemblyjs/ast@1.11.6, npm/@webassemblyjs/wasm-parser@1.11.6, npm/available-typed-arrays@1.0.6, npm/browserslist@4.22.3, npm/call-bind@1.0.6, npm/core-js-compat@3.35.1, npm/define-data-property@1.1.3, npm/elliptic@6.5.4, npm/es-abstract@1.22.3, npm/eslint-webpack-plugin@4.0.1, npm/eslint@8.56.0, npm/flatted@3.2.9, npm/has-property-descriptors@1.0.1, npm/istanbul-reports@3.1.6, npm/karma-firefox-launcher@2.1.2, npm/karma@6.4.2, npm/parse-asn1@5.1.6, npm/sodium-native@4.0.8, npm/typescript@5.3.3, npm/webpack@5.90.1, npm/which-typed-array@1.1.14

View full report↗︎

Copy link

socket-security bot commented Mar 20, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Debug access npm/asn1.js@4.10.1
Debug access npm/enhanced-resolve@5.16.0
  • orphan: npm/enhanced-resolve@5.16.0

View full report↗︎

Next steps

What is debug access?

Uses debug, reflection and dynamic code execution features.

Removing the use of debug will reduce the risk of any reflection and dynamic code execution.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/asn1.js@4.10.1
  • @SocketSecurity ignore npm/enhanced-resolve@5.16.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to bump it's own version to 11.0.1 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could've sworn I did that 🤦 thank you so much, fixed

@sreuland
Copy link
Contributor

is there an approach to test/verify a base version pr branch against js-stellar-sdk locally first, i.e. @stellar/stellar-base: https://github.com/stellar/js-stellar-base.git#v11.0.1, just to confirm js-stellar-sdk builds, passes?

Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Shaptic
Copy link
Contributor Author

Shaptic commented Mar 20, 2024

@sreuland good idea! I just confirmed that it worked locally with a gitref to 00cf120.

@Shaptic Shaptic merged commit 8fe2d8c into master Mar 20, 2024
5 of 6 checks passed
@Shaptic Shaptic deleted the v11.0.1 branch March 20, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants