Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with pre-ES2016 environments (like some React Native JS compilers) by adding a custom Buffer.subarray polyfill #733

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Mar 8, 2024

We need to wait for the new version of js-xdr to be released first.

@overcat overcat changed the title Fix the issue that cannot run in a pre-ES2016 environment. Add compatibility with pre-ES2016 environments (like some React Native JS compilers) by adding a custom Buffer.subarray polyfill Mar 20, 2024
@Shaptic
Copy link
Contributor

Shaptic commented Mar 20, 2024

@overcat @stellar/js-xdr@v3.1.1 is out

@overcat overcat marked this pull request as ready for review March 20, 2024 17:20
@overcat
Copy link
Contributor Author

overcat commented Mar 20, 2024

stellar-base also uses Buffer.subarray

ed25519: rawBytes.subarray(0, -8)

@overcat
Copy link
Contributor Author

overcat commented Mar 20, 2024

Hi @Shaptic, stellar-sdk does not seem to directly use Buffer.subarray, so we do not need to add this polyfill in stellar-sdk for now. We just need to update the version of stellar-base in stellar-sdk.

So next, we need to:

  1. Merge this PR
  2. Release the new stellar-base
  3. Update the stellar-base version in stellar-sdk
  4. Release the new stellar-sdk

@Shaptic Shaptic merged commit 8565309 into stellar:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants