Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove setting BigNumber.DEBUG to true to avoid global impact. #729

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Feb 9, 2024

Closes #727

@overcat overcat force-pushed the big-number-clone branch 2 times, most recently from 74f3815 to 1e9dd18 Compare February 9, 2024 01:46
@overcat overcat changed the title Remove setting BigNumber.DEBUG to true to avoid global impact. Remove setting BigNumber.DEBUG to true to avoid global impact. Feb 9, 2024
@overcat overcat changed the title Remove setting BigNumber.DEBUG to true to avoid global impact. Remove setting BigNumber.DEBUG to true to avoid global impact. Feb 9, 2024
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant solution, thanks! 👏

@Shaptic Shaptic merged commit 5c5da0c into stellar:master Feb 9, 2024
6 checks passed
@overcat overcat deleted the big-number-clone branch February 9, 2024 22:33
@overcat
Copy link
Contributor Author

overcat commented Feb 9, 2024

Hi @Shaptic, when can we release a new version? ledger-live needs it.

@Shaptic
Copy link
Contributor

Shaptic commented Feb 13, 2024

@overcat this is released in v11.0.0 of stellar-base and v11.2.2 of stellar-sdk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we not modify the settings of the default BigNumber instance?
2 participants