Correctly build operations via Contract.call()
#692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -89 B (0%) Total Size: 3.15 MB
|
sreuland
approved these changes
Sep 13, 2023
sreuland
reviewed
Sep 13, 2023
| @@ -59,7 +62,11 @@ describe('Contract', function () { | |||
| StellarBase.nativeToScVal(2, { type: 'i32' }) | |||
| ); | |||
|
|
|||
| xit('builds valid XDR', function () { | |||
| it('works with no parameters', function () { | |||
| contract.call('empty').toXDR(); | |||
There was a problem hiding this comment.
not now, but would the toXDR() output need to be compared with expected output here and on builds valid XDR tests? or if it doesn't throw after serializing, that point is good enough.
There was a problem hiding this comment.
yeah the structure itself is checked in other tests, this is just a "did you build working xdr" test (helps check types, etc. when it isn't marked to skip 🤦)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type of
InvokeContractArgs.functionNameis supposed to be astringnow, not anScSymbollike before.This should have been caught by testing but they were being skipped with
xitby mistake 🤦