Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a withMuxing parameter to all operation options in Typescript. #466

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

Shaptic
Copy link
Contributor

@Shaptic Shaptic commented Sep 13, 2021

What

This allows all operations to set a muxed source account, as required by CAP-27.

Why

While JavaScript consumers of this library are unaffected, as passing extra parameters to functions is always allowed, Typescript libraries will not compile when passing withMuxing: true to any operation.

Copy link

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick turnaround

@Shaptic Shaptic merged commit f73a226 into master Sep 13, 2021
@Shaptic Shaptic deleted the muxed-ts-definition branch September 13, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants