Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use canonical asset format. #277

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Use canonical asset format. #277

merged 1 commit into from
Oct 15, 2019

Conversation

abuiles
Copy link
Contributor

@abuiles abuiles commented Oct 15, 2019

@abuiles abuiles force-pushed the use-canonical-representation-for-asset-to-string branch from 81a1b65 to 9b74fdb Compare October 15, 2019 14:57
morleyzhi
morleyzhi approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@morleyzhi morleyzhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@abuiles abuiles merged commit f83fd78 into master Oct 15, 2019
@abuiles abuiles deleted the use-canonical-representation-for-asset-to-string branch October 15, 2019 17:45
@abuiles abuiles mentioned this pull request Oct 15, 2019
Merged
Akuukis
Akuukis reviewed Oct 16, 2019
View reviewed changes
test/unit/asset_test.js
'USD-GCEZWKCA5VLDNRLN3RPRJMRZOX3Z6G5CHCGSNFHEYVXM3XOJMDS674JZ'
);
});
it("returns 'code-issuer' for non-native asset", function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo - need code:issuer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuukis Akuukis Akuukis left review comments

@morleyzhi morleyzhi morleyzhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abuiles @morleyzhi @Akuukis