-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support stellar-core protocol 12 #274
Conversation
Beautiful! I was just about to ask :) |
37d555e
to
ee1d1bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question.
CHANGELOG.md
Outdated
|
||
- `Operation.pathPaymentStrictSend`: Sends a path payments, debiting from the source account exactly an specified amount of one asset, crediting at least a given amount of another asset. ([#274](https://github.com/stellar/js-stellar-base/pull/274)). | ||
|
||
The following operation will debit exactly $10 USD from the source acount, crediting at least $9.2 EUR in the destination account 💸: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following operation will debit exactly $10 USD from the source acount, crediting at least $9.2 EUR in the destination account 💸: | |
The following operation will debit exactly 10 USD from the source acount, crediting at least 9.2 EUR in the destination account 💸: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bartekn oh, good catch! I won't apply the suggestion but do it as a commit on my machine since I used $ somewhere else
Add support for stellar-core protocol 12 release and CAP 24 ("Make PathPayment Symmetrical").
Add ➕
Operation.pathPaymentStrictSend
: Sends a path payment, debiting from the source account exactly a specified amount of one asset, crediting at least a given amount of another asset.The following operation will debit exactly 10 USD from the source account, crediting at least 9.2 EUR in the destination account 💸:
Operation.pathPaymentStrictReceive
: This behaves the same as the formerpathPayments
operation.The following operation will debit maximum 10 USD from the source account, crediting exactly 9.2 EUR in the destination account 💸:
Deprecated ❗️
Operation.pathPayment
is being deprecated in favor ofOperation.pathPaymentStrictReceive
. Both functions take the same arguments and behave the same.