Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spec): unwrap result when parsing return value #138

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(spec): unwrap result when parsing return value #138

merged 2 commits into from
Sep 11, 2023

Conversation

willemneal
Copy link
Member

@willemneal willemneal commented Sep 8, 2023 •
edited
Loading

This PR unwraps the result type's ok type so that it can be parsed correctly. The error type is used when if it throws.
fixes: stellar/stellar-cli#935

Shaptic
Shaptic approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small non-blocking nit, otherwise lgtm! a changelog entry would also be appreciated

src/contract_spec.ts Outdated Show resolved Hide resolved
@willemneal @Shaptic
Update contract_spec.ts
b18c843 
Co-authored-by: George <Shaptic@users.noreply.github.com>
@willemneal willemneal merged commit 4b77acf into stellar:main Sep 11, 2023
4 checks passed
@willemneal willemneal deleted the fix/spec_enums branch September 11, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shaptic Shaptic Shaptic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@willemneal @Shaptic