remove params from jsonrpc post payload if empty, rpc requires it (#70)

stellar · Apr 26, 2023 · a52897f · a52897f
1 parent cc796e5
commit a52897f
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/src/jsonrpc.ts b/src/jsonrpc.ts
@@ -35,6 +35,9 @@ export async function post<T>(
   method: string,
   ...params: any
 ): Promise<T> {
+  if (params && params.length < 1) {
+    params = null;
+  }
   const response = await axios.post<Response<T>>(url, {
     jsonrpc: "2.0",
     // TODO: Generate a unique request id

diff --git a/test/unit/server/get_health_test.js b/test/unit/server/get_health_test.js
@@ -22,7 +22,7 @@ describe("Server#getHealth", function() {
         jsonrpc: "2.0",
         id: 1,
         method: "getHealth",
-        params: [],
+        params: null,
       })
       .returns(Promise.resolve({ data: { result } }));
 

diff --git a/test/unit/server/get_latest_ledger_test.js b/test/unit/server/get_latest_ledger_test.js
@@ -23,7 +23,7 @@ describe("Server#getLatestLedger", function() {
         jsonrpc: "2.0",
         id: 1,
         method: "getLatestLedger",
-        params: [],
+        params: null,
       })
       .returns(Promise.resolve({ data: { result } }));
 

diff --git a/test/unit/server/get_network_test.js b/test/unit/server/get_network_test.js
@@ -23,7 +23,7 @@ describe("Server#getNetwork", function() {
         jsonrpc: "2.0",
         id: 1,
         method: "getNetwork",
-        params: [],
+        params: null,
       })
       .returns(Promise.resolve({ data: { result } }));
 

diff --git a/test/unit/server/request_airdrop_test.js b/test/unit/server/request_airdrop_test.js
@@ -63,7 +63,7 @@ describe("Server#requestAirdrop", function() {
         jsonrpc: "2.0",
         id: 1,
         method: "getNetwork",
-        params: [],
+        params: null,
       })
       .returns(Promise.resolve({ data: { result } }));
   }