-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
services/horizon/internal/ingest: Add metrics for ingestion loaders #5209
Conversation
since 2.28.3 went out last week unfortunately on a bit of rush, this needs to target master now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@sreuland I think I have addressed all your feedback, could you take another look? |
looks good, and thanks for consideration on suggestions! do need to re-target this pr to merge to |
3cf3dc9
to
0ed0e10
Compare
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #5154
We do not have any metrics capturing how long it takes to run the ingestion loaders:
https://github.com/stellar/go/blob/release-horizon-v2.28.0/services/horizon/internal/ingest/group_processors.go#L101-L105
This commit adds prometheus metrics for the duration of each loader so we can determine how much of ingestion is spent in the loaders vs the processors. We also added prometheus metrics capturing how many records were queried and inserted during the execution of each loader.
Known limitations
[N/A]