ingest/ledgerbackend: Remove captive core info request error logs #5145
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Captive core configures two prometheus metrics which periodically probe the info http endpoint on captive core. If the info request fails, we currently log the error.
Why
This commit removes the logs because we are already probing the info http endpoint and logging errors in https://github.com/stellar/go/blame/master/services/horizon/internal/app.go#L401C15-L401C36 . Therefore the logs here are redundant. Also, in #4894 and #5108 we added logic to suppress error logs during the build state, and if we keep this logging code we will have to reimplement this logic again.
Known limitations
[N/A]