services/horizon/internal: Fix configuration of captive core in reingest command #5069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urvisavla
reviewed
Sep 27, 2023
- Include validation for an empty captive-core-config-path in the regular ingestion process with captive core. - Update unit tests to cover different scenarios of captive-core-config-paths, for both ingestion where "RequireCaptiveCoreConfig" is True and reingestion where "RequireCaptiveCoreConfig" is False.
sreuland
reviewed
Sep 28, 2023
sreuland
approved these changes
Oct 3, 2023
2opremio
pushed a commit
that referenced
this pull request
Oct 16, 2023
…est command (#5069) * Fix configuration of captive core in reingest command * Add validation for an empty --captive-core-config-path. --------- Co-authored-by: Urvi <urvi.savla@stellar.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
When running
horizon --db-url postgres://postgres@localhost:5432?sslmode=disable --apply-migrations db reingest range 48263265 48263265with the following environment variables:I encountered the error listed below:
It looks like this regression was introduced in https://github.com/stellar/go/pull/4949/files . Prior to #4949 we were overriding
config.CaptiveCoreTomlParams.CoreBinaryPath,config.CaptiveCoreTomlParams.HistoryArchiveURLs, andconfig.CaptiveCoreTomlParams.NetworkPassphrasebefore constructing the captive core toml. But, it seems like we missed one of the cases inIt looks like this regression was introduced in https