Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition in integration test #4994

Merged
merged 4 commits into from
Jul 28, 2023

Conversation

aditya1702
Copy link
Contributor

@aditya1702 aditya1702 commented Jul 28, 2023

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Fixes a race condition in testing ingestion-filtering flag.

Closes #4987

Update command_line_args_test.go

Remove command_line_args_test.go
@aditya1702 aditya1702 force-pushed the fix-race-condition branch from 0ee8714 to c5de287 Compare July 28, 2023 15:44
Copy link
Contributor

@sreuland sreuland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for converging the tests into parameters_test.go also!

@2opremio
Copy link
Contributor

@aditya1702 the import ordering is wrong again. I would recommend using an IDE which sorts it automatically for you (both Goland and, I believe, VsCode should be able to do it automatically for you)

@aditya1702
Copy link
Contributor Author

@aditya1702 the import ordering is wrong again. I would recommend using an IDE which sorts it automatically for you (both Goland and, I believe, VsCode should be able to do it automatically for you)

@2opremio I dont see the error for the wrong import ordering. Were you looking at the latest version of the PR?

@aditya1702 aditya1702 merged commit 62bc09d into stellar:master Jul 28, 2023
@2opremio
Copy link
Contributor

Ah, true, thanks

@aditya1702 aditya1702 deleted the fix-race-condition branch August 1, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition found in Horizon Ingestion filtering Integration tests
3 participants