-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race condition in integration test #4994
Conversation
Update command_line_args_test.go Remove command_line_args_test.go
0ee8714
to
c5de287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for converging the tests into parameters_test.go also!
@aditya1702 the import ordering is wrong again. I would recommend using an IDE which sorts it automatically for you (both Goland and, I believe, VsCode should be able to do it automatically for you) |
@2opremio I dont see the error for the wrong import ordering. Were you looking at the latest version of the PR? |
Ah, true, thanks |
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Fixes a race condition in testing ingestion-filtering flag.
Closes #4987