services/horizon/cmd: Check ingest flag before executing horizon db migrate commands #4664
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot
, orall
ordoc
if the changes are broad or impact manypackages.
Thoroughness
.md
files, etc... affected by this change). Take a look in the
docs
folder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Close #4580
Only apply migrations in the
horizon db migrate commands
if theingest
flag is true.Why
The horizon postinstall script in debian runs the
db migrate up
commandhttps://github.com/stellar/packages/blob/master/stellar-horizon/debian/stellar-horizon.postinst#L44
However, this command will fail if horizon is configured to use a read only connection (e.g. horizon is configured for request serving but not ingestion). When the command fails the debian installation will also fail.
To fix this issue we check that horizon ingestion is enabled before attempting to execute migrations. If ingestion is not enabled we print a warning and skip the migrations entirely.
Known limitations
Note that no error is returned if ingestion is disabled even though ingestion is a prerequisite for running the
db migrate up
command. Although this is a bit counter intuitive, it is consistent with the behavior of the--apply-migrations
flag #3586