Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all: Forgot to add sudo in #4266 #4270

Merged
merged 1 commit into from
Mar 12, 2022
Merged

all: Forgot to add sudo in #4266 #4270

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-go/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@ runs:
# and that the module cache is cleaned (otherwise it accumulates orphan dependencies over time).
- if: github.ref_protected
shell: bash
run: rm -r ~/.cache/go-build ~/go/pkg/mod
run: sudo rm -r ~/.cache/go-build ~/go/pkg/mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd to me that sudo is required when these directories are written to the home directory and they're written by a regular user, not a super user. Or maybe it is the superuser as implied by actions/cache#512. It would be interesting to see who the owning user and group is, and what permissions are set on the files by running ls -lah in the directory.