services/horizon: Update cursor when bumping ledger to latest #4150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sreuland
reviewed
Dec 22, 2021
| @@ -416,6 +416,14 @@ func (r resumeState) run(s *system) (transition, error) { | |||
| log.WithField("ingestLedger", ingestLedger). | |||
| WithField("lastIngestedLedger", lastIngestedLedger). | |||
| Info("bumping ingest ledger to next ledger after ingested ledger in db") | |||
|
|
|||
| // Update cursor if there's more than one ingesting instance: either | |||
There was a problem hiding this comment.
ingestLedger <= lastIngestedLedger is a state that can only happen due to multiple ingestions instances? just wanted to understand the comment which refers to it, would a single ingestion instance ever get in here, i.e. this is a best effort attempt under any case?
There was a problem hiding this comment.
Correct, this can only happen if there is more than one ingesting instance. ingestLedger is the currently ingested ledger in this instance, lastIngestedLedger is the last ingested ledger in the cluster. I guess the variable names could be better.
sreuland
approved these changes
Dec 22, 2021
tamirms
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Update cursor in Stellar-Core to latest ingested ledger when local ingestion is behind the cluster.
Why
If there is a DB ingesting instance more than one ingesting instance: either Captive-Core or DB connected to another Stellar-Core, it's possible that the cursor will be updated very rarely. This will make the Stellar-Core DB size bloat as the old ledger will not be removed.
Known limitations
[TODO or N/A]