Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

services/horizon: Add txsub integration test #3689

Merged

Conversation

bartekn
Copy link
Contributor

@bartekn bartekn commented Jun 14, 2021

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with name of package that is most changed in the PR, ex.
    services/friendbot, or all or doc if the changes are broad or impact many
    packages.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated any docs (developer docs, .md
    files, etc... affected by this change). Take a look in the docs folder for a given service,
    like this one.

Release planning

  • I've updated the relevant CHANGELOG (here for Horizon) if
    needed with deprecations, added features, breaking changes, and DB schema changes.
  • I've decided if this PR requires a new major/minor version according to
    semver, or if it's mainly a patch change. The PR is targeted at the next
    release branch if it's not a patch change.

What

Adds sanity integration test for txsub. Add a test (submit_transaction_test.go) I forgot to include in #3653.

Why

While we have some unit tests for txsub we don't test the transaction submission endpoint during mirroring test. A simple integration test should at least catch the most obvious bugs.

Known limitations

[TODO or N/A]

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@bartekn bartekn force-pushed the txsub-integration-test branch from 144129c to 2b4986f Compare June 14, 2021 21:45
@bartekn bartekn marked this pull request as ready for review June 14, 2021 21:45
@bartekn bartekn requested a review from a team June 14, 2021 21:45
@bartekn bartekn added this to the Horizon 2.5.0 milestone Jun 14, 2021
duh

Unverified

This user has not yet uploaded their public signing key.
@tamirms
Copy link
Contributor

tamirms commented Jun 15, 2021

Don't all the existing integration tests exercise txsub because they all submit transactions to horizon?

@bartekn
Copy link
Contributor Author

bartekn commented Jun 15, 2021

Correct but they all do it synchronously and submit only one tx per account at a time. I'm worried that changes like #3563 can introduce subtle bugs we won't catch using unit tests and simple testing.

@bartekn bartekn merged commit eac9373 into stellar:release-horizon-v2.5.0 Jun 15, 2021
@bartekn bartekn deleted the txsub-integration-test branch June 15, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants