services/horizon: Test full coverage of operation type switches #3560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
changed the title
tamirms
approved these changes
Apr 24, 2021
bartekn
approved these changes
Apr 26, 2021
| // make sure the check works for an unreasonable operation type | ||
| _, err := UnmarshalOperation(200000, []byte{}) | ||
| assert.Error(t, err) | ||
| assert.Equal(t, mistmatchErr, err) |
There was a problem hiding this comment.
Nit, there's EqualError that can be useful here.
There was a problem hiding this comment.
I didn't know, thanks! However, the error is currently identical, so I think it's fine.
There was a problem hiding this comment.
Yeah, I mean, you can merge Error and Equal intro EqualError but the current is fine obviously.
2opremio
force-pushed
the
3430-test-coverage-of-op-switches
branch
from
f09e5d4 to
255f360
Compare
2opremio
force-pushed
the
3430-test-coverage-of-op-switches
branch
from
255f360 to
c111c4e
Compare
2opremio
force-pushed
the
3430-test-coverage-of-op-switches
branch
from
c111c4e to
04038a2
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3430
I incorporated new tests, which use
xdr'soperationTypeMap(now exported asOperationTypeToStringMap) to go over all possible operations, even when we incorporate new ones.The idea is that, from now on, every time we add a new XDR operation (i.e. through a CAP), the developer gets guided on what needs to be modified based on the failing tests.
The tests I added can be considered finicky, but it's hard to do it generically in a robust way.