services/horizon: Avoid waiting for the first checkpoint in captive-core online mode #3201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2opremio
commented
Nov 9, 2020
| @@ -284,28 +284,29 @@ func (c *CaptiveStellarCore) runFromParams(from uint32) (runFrom uint32, ledgerH | |||
| } | |||
|
|
|||
| if from <= 63 { | |||
There was a problem hiding this comment.
Maybe we should provide the hash when from from == 63?
2opremio
force-pushed
the
do-not-wait-until-first-checkpoint
branch
2 times, most recently
from
aaaf23d to
5ef5c56
Compare
bartekn
approved these changes
Nov 10, 2020
|
@2opremio I thought this depends on rokopt/stellar-core@3cea6ee which, as far as I know, has not been released in stellar core? |
AFAIU, that change is to allow providing |
2opremio
force-pushed
the
do-not-wait-until-first-checkpoint
branch
from
5ef5c56 to
b1672af
Compare
tamirms
added a commit
to tamirms/go
that referenced
this pull request
Dec 4, 2020
… mode (stellar#3201)" This reverts commit a25756d.
7 tasks
tamirms
added a commit
that referenced
this pull request
Dec 4, 2020
…meter is omitted (#3265) In #3201 we assumed it was possible to omit the --start-at-hash parameter when starting from the genesis ledger. However, Stellar Core actually fails when attempting that command. The --start-at-hash parameter is always required when using --start-at-ledger. This means that if we want to stream from the genesis ledger we need to determine the either the horizon db or the history archives.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As discussed with @rokopt and @graydon , there is no need to provide a ledger hash when streaming from ledger before the first checkpoint.
Why
It allows Horizon to start ingesting before the first checkpoint is reached (which incurs in a ~5min wait when ingesting from the beginning).
Known limitations
N/A