Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clients/horizonclient+txnbuild: Update CHANGELOGs for horizonclient 4.0 release #3074

Conversation

2opremio
Copy link
Contributor

No description provided.

@2opremio 2opremio requested review from a team September 29, 2020 16:01
@cla-bot cla-bot bot added the cla: yes label Sep 29, 2020
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

@2opremio 2opremio force-pushed the release-horizonclient-update-changelogs branch from ae946d3 to 497c6d6 Compare September 29, 2020 16:10
Copy link
Contributor

@JakeUrban JakeUrban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As Leigh mentioned, the SEP-10 SDK changes need to be mentioned as a breaking and urgent change for SEP-10 web servers.

@2opremio
Copy link
Contributor Author

As Leigh mentioned, the SEP-10 SDK changes need to be mentioned as a breaking and urgent change for SEP-10 web servers.

I think they are, see https://github.com/stellar/go/pull/3074/files#diff-2b08be9bbafc2b75990ded968157d60aL21 (I preserved what was in the CHANGELOG)

If you need any further changes, feel free to push them to this PR.

Copy link
Contributor

@ire-and-curses ire-and-curses left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@2opremio 2opremio merged commit 98db741 into stellar:release-horizonclient-v4.0.0 Sep 29, 2020
@2opremio 2opremio deleted the release-horizonclient-update-changelogs branch September 29, 2020 18:05
tamirms pushed a commit to tamirms/go that referenced this pull request Oct 2, 2020
….0 release (stellar#3074)


Co-authored-by: Leigh McCulloch <leigh@mcchouse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants