services/horizon: Improve /accounts/{id}/transactions|payments|operations performance #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the storage overhead of the new columns and indices? |
|
I will confirm it this week. I think new fields won't require much storage because these are just |
tamirms
reviewed
Aug 25, 2020
| @@ -213,11 +227,21 @@ func (p *ParticipantsProcessor) addOperationsParticipants( | |||
| return errors.Wrap(err, "could not determine operation participants") | |||
| } | |||
|
|
|||
| for operationID, p := range participants { | |||
| for operationIndex, p := range participants { | |||
| operationID := toid.New( | |||
There was a problem hiding this comment.
why are we constructing a toid here? it seems like the old code was not creating any toid
|
Closing for now. We can reopen it in the future when fixing all performance issues in a batch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit improves the performance of
/accounts/{id}/transactions|payments|operationsendpoints by denormalizinghistory_operation_participantsandhistory_transaction_participants. The feature is behind a feature flag because to work correctly a new set of indexes and full history reingestion are required.Why
As explained in #1808 the set of queries made by "Transactions/Operations/Payments For Account" endpoints require denormalization of
history_operation_participantsandhistory_transaction_participantstables to include information about a transaction status (successful) and operation type (payment). This makes queries related to accounts with unusual operation distributions (ex. an account with a lot of offer operations but a few payment operations) fast.Known limitations