exp/ingest/ledgerbackend: Handle Stellar-Core process exit gracefully #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartekn
commented
Jul 10, 2020
| return | ||
| case c.metaC <- metaResult{meta, nil}: | ||
| } |
There was a problem hiding this comment.
I simplified this code. There's no need to check c.stop here because even we discard one result from metaC in Close to unblock it. So even if the code is waiting here, it will be unlocked by Close.
abuiles
approved these changes
Jul 10, 2020
| @@ -271,6 +286,20 @@ func (c *CaptiveStellarCore) PrepareRange(ledgerRange Range) error { | |||
| } | |||
|
|
|||
| for { | |||
| select { | |||
| case <-c.shutdown: | |||
| return nil | |||
There was a problem hiding this comment.
@bartekn should we call c.Close() here too before returning - is seem like sendLedgerMeta could still be running on the goroutine
There was a problem hiding this comment.
No, because c.shutdown can be only closed by calling c.Close. So it implies that c.Close was called.
abuiles
approved these changes
Jul 13, 2020
This was referenced Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
needed with deprecations, added features, breaking changes, and DB schema changes.
semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
This commit adds a code that handles Stellar-Core process exit gracefully. Added
processExitunbuffered channel tostellarCoreRunnerthat receives the error in case Stellar-Core crashed or was terminated with an error or nil error if it was shutdown gracefully. The channel is later used inPrepareRangethat returns an error if the process was stopped while prepare was running and insendLedgerMetathat adds error to a meta channel that will be read by one of the followingGetLedgercalls.Close #2705.
Why
Right now when Stellar-Core crashes,
CaptiveStellarCoresimply wait for the next ledger without restarting it.